Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22741 Update CLDR-ICU instructions to mention some hardcoded lists that may need updating #3068

Merged
merged 1 commit into from
Jul 26, 2024
Merged

ICU-22741 Update CLDR-ICU instructions to mention some hardcoded lists that may need updating #3068

merged 1 commit into from
Jul 26, 2024

Conversation

pedberg-icu
Copy link
Contributor

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22741
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

macchiati
macchiati reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are these also in ICU4J?

@pedberg-icu
Copy link
Contributor Author

Looks good. Are these also in ICU4J?

ICU4J just has the measure unit lists (including currency) that get generated as part of the process in https://unicode-org.github.io/icu/processes/release/tasks/updating-measure-unit.html

@macchiati
Copy link
Member

macchiati commented Jul 26, 2024 via email

srl295
srl295 previously approved these changes Jul 26, 2024
View reviewed changes
srl295
srl295 reviewed Jul 26, 2024
View reviewed changes
docs/processes/cldr-icu.md Outdated Show resolved Hide resolved
@srl295
Copy link
Member

srl295 commented Jul 26, 2024

Suggested to link to an actual ticket.

@pedberg-icu
ICU-22741 Update CLDR-ICU instructions to mention some hardcoded list…
aee4356 
…s that may need updating

Co-authored-by: Steven R. Loomis <srl295@gmail.com>
@pedberg-icu pedberg-icu force-pushed the ICU-22741-update-cldr-icu-instructions-for-hardcoded-lists branch from c2c3f99 to aee4356 Compare July 26, 2024 16:15
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@pedberg-icu
Copy link
Contributor Author

Suggested to link to an actual ticket.

@srl295 Thanks, good idea, added that. Now needs re-stamp...🙂

@pedberg-icu pedberg-icu merged commit 2cbfd13 into unicode-org:main Jul 26, 2024
11 checks passed
@pedberg-icu pedberg-icu deleted the ICU-22741-update-cldr-icu-instructions-for-hardcoded-lists branch July 26, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati left review comments

@srl295 srl295 srl295 approved these changes

@mihnita mihnita Awaiting requested review from mihnita

@markusicu markusicu Awaiting requested review from markusicu

@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

Assignees

@DraganBesevic DraganBesevic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pedberg-icu @macchiati @srl295 @DraganBesevic